From: Alexander Smirnov <fredeom@mail.ru>
Date: Wed, 4 Sep 2024 14:28:57 +0000 (+0300)
Subject: [ERP-137] ранее использовались ключи дополнительных полей, теперь коды
X-Git-Tag: 1.4~4^2
X-Git-Url: https://gitweb.erp-flowers.ru/?a=commitdiff_plain;h=392a13d24a410e9204fa9519fdbd5d5db9da0baf;p=erp24_rep%2Fyii-erp24%2F.git

[ERP-137] ранее использовались ключи дополнительных полей, теперь коды
---

diff --git a/erp24/services/MotivationService.php b/erp24/services/MotivationService.php
index c1b24222..38b19c44 100644
--- a/erp24/services/MotivationService.php
+++ b/erp24/services/MotivationService.php
@@ -663,9 +663,9 @@ class MotivationService
     public static function calculateMonthForecast($store_id, $year, $month) {
         $motivationCostsItem = MotivationCostsItem::find()->all();
         $motivationCostsItemCodes = ArrayHelper::getColumn($motivationCostsItem, 'code');
-        $additionalItemsKeys = array_keys(self::$additionalItems);
+        $additionalItemsCodes = ArrayHelper::getColumn(self::$additionalItems, 'code');
 
-        $items = array_merge($motivationCostsItemCodes, $additionalItemsKeys);
+        $items = array_merge($motivationCostsItemCodes, $additionalItemsCodes);
 
         $motivationValueGroups = [];
         foreach (range(1, 5) as $ind) {
@@ -698,21 +698,7 @@ class MotivationService
                         };
                     }
                 }
-                if (!$motivationValue) {
-                    $motivationValue = new MotivationValue;
-                    $motivationValue->motivation_id = $motivation->id;
-                    $motivationValue->motivation_group_id = $motivationValueGroupForecast->id;
-                    $motivationValue->value_id = $code;
-                }
-                $motivationValue->value_type = $sum_type;
-                switch ($sum_type) {
-                    case MotivationCostsItem::DATA_TYPE_INT: { $motivationValue->value_int = $sum; break; }
-                    default: { $motivationValue->value_float = $sum; break; }
-                }
-                $motivationValue->save();
-                if ($motivationValue->getErrors()) {
-                    throw new \Exception(Json::encode($motivationValue->getErrors()));
-                }
+                self::saveOrUpdateMotivationValue($motivation->id, "forecast", $code, $sum_type, $sum);
             }
         }
     }