From: fomichev <vladimir.fomichev@erp-flowers.ru>
Date: Mon, 18 Nov 2024 12:48:51 +0000 (+0300)
Subject: Замена метода и рефакторинг
X-Git-Tag: 1.7~227^2
X-Git-Url: https://gitweb.erp-flowers.ru/?a=commitdiff_plain;h=30fe768207d98b39670212cec49716b8b1382c01;p=erp24_rep%2Fyii-erp24%2F.git

Замена метода и рефакторинг
---

diff --git a/erp24/actions/log/CollectAction.php b/erp24/actions/log/CollectAction.php
index c6a8faa6..1e81b6ea 100755
--- a/erp24/actions/log/CollectAction.php
+++ b/erp24/actions/log/CollectAction.php
@@ -37,7 +37,7 @@ class CollectAction extends Action
             }*/
 
 
-            $isDev = TelegramService::isDevelopmentEnvironment(TelegramService::TARGET_PROD_URL);
+
 
             // Формируем сообщение для отправки в Telegram с использованием MarkdownV2
             $errorMessage = "⚠️*Ошибка JavaScript Обнаружена*⚠️\n\n";
@@ -45,7 +45,7 @@ class CollectAction extends Action
 
             if ($url = $this->controller->request->getReferrer()) {
                 $errorMessage .= "*URL:*\n```" . TelegramService::escapeMarkdownLog($url) . "```\n\n";
-                $isDev = !str_contains($url, TelegramService::TARGET_PROD_URL);
+                $isDev = TelegramService::isDevelopmentEnvironment($url);
             }
 
             if ($createdAt = date('Y-m-d H:i:s', $log->log_time)) {
diff --git a/erp24/log/TelegramTarget.php b/erp24/log/TelegramTarget.php
index 5c410326..961d5add 100644
--- a/erp24/log/TelegramTarget.php
+++ b/erp24/log/TelegramTarget.php
@@ -108,14 +108,10 @@ class TelegramTarget extends \yii\log\Target
 
         $message = new Message($this->messages[0]);
 
-
         $errorUrl = $message->getUrl();
 
-        if(!empty($errorUrl)){
-            $isDev = !str_contains($errorUrl, TelegramService::TARGET_PROD_URL);
-        }else {
-            $isDev = TelegramService::isDevelopmentEnvironment(TelegramService::TARGET_PROD_URL);
-        }
+        $isDev = TelegramService::isDevelopmentEnvironment($errorUrl);
+
 
 
 
diff --git a/erp24/services/InfoLogService.php b/erp24/services/InfoLogService.php
index 636a1c02..22ceb6ea 100644
--- a/erp24/services/InfoLogService.php
+++ b/erp24/services/InfoLogService.php
@@ -35,7 +35,7 @@ class InfoLogService
                 return;
             }*/
 
-            $isDev = TelegramService::isDevelopmentEnvironment(TelegramService::TARGET_PROD_URL);
+            $isDev = TelegramService::isDevelopmentEnvironment();
 
             $telegramMessage = "⚠️*Сообщение из InfoLog*⚠️\n\n";
 
diff --git a/erp24/services/LogService.php b/erp24/services/LogService.php
index 022678f7..53ad71f3 100644
--- a/erp24/services/LogService.php
+++ b/erp24/services/LogService.php
@@ -68,7 +68,6 @@ class LogService
             }*/
 
 
-            $isDev = TelegramService::isDevelopmentEnvironment(TelegramService::TARGET_PROD_URL);
 
                 // Форматирование сообщения об ошибке с условным добавлением строк
             $errorMessage = "⚠️*Ошибка API Обнаружена*⚠️\n\n";
@@ -76,7 +75,7 @@ class LogService
             // Добавляем строки только если параметры присутствуют
             if ($url = $apiErrorLog->url) {
                 $errorMessage .= "*URL:*\n```" . TelegramService::escapeMarkdownLog($url) . "```\n\n";
-                $isDev = !str_contains($url, TelegramService::TARGET_PROD_URL);
+                $isDev = TelegramService::isDevelopmentEnvironment($url);
             }
 
             if ($createdAt = $apiErrorLog->created_at) {
diff --git a/erp24/services/TelegramService.php b/erp24/services/TelegramService.php
index 02ca1735..1b0ab9c9 100644
--- a/erp24/services/TelegramService.php
+++ b/erp24/services/TelegramService.php
@@ -22,10 +22,10 @@ class TelegramService {
         return $client->request('GET', $url);
     }
 
-     public static function isDevelopmentEnvironment($prodUrl) : bool
+     public static function isDevelopmentEnvironment($urlString = null) : bool
      {
-         $currentUrl = Yii::$app->request->getHostInfo();
-         return !str_contains($currentUrl, $prodUrl);
+         $currentUrl = empty($urlString) ? Yii::$app->request->getHostInfo() : $urlString;
+         return !str_contains($currentUrl, self::TARGET_PROD_URL);
      }
 
 public static function sendErrorToTelegramMessage($message,$disableNotification, $isDev)